Skip to content

Add support for Two Hand Mastery socket line - #10409

Open
mcagnion wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
mcagnion:bugfix/two-hand-mastery-sockets
Open

mcagnion wants to merge 1 commit into
PathOfBuildingCommunity:devfrom
mcagnion:bugfix/two-hand-mastery-sockets

Conversation

@mcagnion

@mcagnion mcagnion commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

The Two Hand Mastery line 30% increased Armour and Evasion Rating if your Main Hand Weapon has a Red and Green Socket was not parsed. The tree showed it as "Not supported in PoB yet" and it added nothing to the character. This line replaced the two per-socket lines of this mastery in the 3.29.0 patch notes.

It is now read as a red and a green socket on the main hand weapon, in the same way as the Staff Mastery line from #10067.

Steps taken to verify a working solution:

  • Added an item test: the line gives 30% with R-G sockets and nothing with R-B or G-B.
  • Allocated the mastery with an R-G Lion Sword equipped. Armour goes from 1,240 to 1,540 and Evasion from 1,928 to 2,379. The node tooltip now shows the stat differences for unallocating it.
  • The Armour Total Increased breakdown in the Calcs tab now lists the mastery with both socket conditions, 30 on top of Sentinel's 24.

Before screenshot:

before-mastery-tooltip before-armour-total-increased

After screenshot:

after-mastery-tooltip after-armour-total-increased

The line lost its condition while parsing, so it granted nothing. Read it as a red and a green socket on the main hand weapon, as the Staff Mastery line does for its sockets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant